From fc8d4c1c6878cee1ae995de11bea63e6220f7c6a Mon Sep 17 00:00:00 2001
From: Akif9748 <akif9748@gmail.com>
Date: Sun, 3 Apr 2022 19:55:33 +0300
Subject: [PATCH] Better paths

---
 README.md         | 1 -
 routes/message.js | 4 ++--
 routes/users.js   | 2 +-
 views/thread.ejs  | 7 ++-----
 views/user.ejs    | 2 +-
 5 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index 573862b..76eb730 100644
--- a/README.md
+++ b/README.md
@@ -24,7 +24,6 @@ And, you can learn informations about API in `APIDOCS.md`.
 - Better DB writing. Example, not `message.author.id`, `messsage.authorID`
 - `/errors/error` will change, better error page.
 - Support for not logins...
-- message/react/:id ❌ message/:id/react ✔️
 
 ## Roadmap
 - [x] User
diff --git a/routes/message.js b/routes/message.js
index 1e47cb4..ca06af1 100644
--- a/routes/message.js
+++ b/routes/message.js
@@ -34,7 +34,7 @@ app.post("/", (req, res) => {
 });
 
 
-app.post("/delete/:id", (req, res) => {
+app.post("/:id/delete", (req, res) => {
     if (!req.session.loggedin) return res.redirect('/login');
 
     const message = new Message().getId(req.params.id)
@@ -49,7 +49,7 @@ app.post("/delete/:id", (req, res) => {
     res.status(200).redirect("/threads/" + message.thread.id);
 
 })
-app.post("/react/:id", (req, res) => {
+app.post("/:id/react", (req, res) => {
     if (!req.session.loggedin) return res.redirect('/login');
 
     const { id = null } = req.params;
diff --git a/routes/users.js b/routes/users.js
index 43f86a6..fff3dcc 100644
--- a/routes/users.js
+++ b/routes/users.js
@@ -36,7 +36,7 @@ app.get("/:id", (req, res) => {
     else error(res, 404, "We have not got this user.");
 
 });
-app.post("/delete/:id", (req, res) => {
+app.post("/:id/delete/", (req, res) => {
     if (!req.session.loggedin) return res.redirect('/login');
     const user = new User().getId(req.session.userid);
     if (!user.admin)
diff --git a/views/thread.ejs b/views/thread.ejs
index 97f236a..0bd3a21 100644
--- a/views/thread.ejs
+++ b/views/thread.ejs
@@ -27,14 +27,11 @@
           <h2>
             <%= message.content %>
           </h2>
-          <form style="text-align:right;display:inline;" action="/message/delete/<%= message.id %>" method="post">
+          <form style="text-align:right;display:inline;" action="/message/<%= message.id %>/delete/" method="post">
             <button style="display:inline;" class="button" type="submit">DELETE</button>
           </form>
 
-
-          <form style="display:inline;" action="/message/<%= message.id %>" method="delete">
-          </form>
-          <form style="text-align:right;" action="/message/react/<%= message.id %>" method="POST">
+          <form style="text-align:right;" action="/message/<%= message.id %>/react/" method="POST">
 
             <h3 style="display:inline;">
               <%= Object.values(message.react).filter(Boolean).length - Object.values(message.react).filter(x=>
diff --git a/views/user.ejs b/views/user.ejs
index 7ecc31e..0b26ade 100644
--- a/views/user.ejs
+++ b/views/user.ejs
@@ -47,7 +47,7 @@
 
         </form>
 
-        <form action="/users/delete/<%= member.id %>" method="POST">
+        <form action="/users/<%= member.id %>/delete" method="POST">
           <button class="buyuk" type="submit">Delete user!</button>
         </form>
         <% }; %>